Standardize text files on UTF-8 without BOM - #1723
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1723 +/- ##
======================================
Coverage 98% 98%
======================================
Files 514 514
Lines 24141 24141
======================================
Hits 23748 23748
Misses 393 393
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Motivation
UTF-8 has no byte-order ambiguity, so its BOM only serves as an encoding signature. Unicode permits but does not require it, and W3C recommends avoiding it unless a compatibility requirement exists because it can interfere with tools or formats that expect content at byte zero.
This also aligns authored files with the explicit UTF-8-without-BOM behavior recently adopted by CodeGen and prevents future encoding-only review noise.
References:
Impact
This is an encoding-only normalization. No source, project, resource, documentation, or unit-definition content changes.
Validation
generate-code.batdotnet restore UnitsNet.slnxdotnet build UnitsNet.slnx --no-restore— succeeded with 18 existing obsolete-API warnings and 0 errors.git diff --check